-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[itest]: missing itest for funding timeout case of 2016 blocks #9511
Comments
Yeah would be nice to revive #7228, plus I don't think we need to mine that many blocks in the itest, this value can be changed using a build tag such that for |
That makes sense! I was thinking of using a build tag to override MaxWaitNumBlocksFundingConf for integration tests, reducing it to a much lower value so we don’t have to mine too many blocks while still triggering the timeout case. Would this approach be a good way to minimize block mining? |
You can make it a configurable value, but expose the flag to actually configure it only in dev/integration test builds by adding it here: Line 23 in ab7aae0
|
Is this what you meant—making |
Could I be assigned to this issue if it's available to work on? |
@Rakshitsinghhh are you wanting to work on this issue or can @NishantBansal2003 work on it? |
Hi @Crypt-iQ, I haven't received a response from @Rakshitsinghhh yet. Would you prefer that I start working on this issue, or should I wait for his input? Thanks! |
It's been two days, you can go ahead and take it 👍 |
Noticed this when looking through the code. We should be able to modify this constant
lnd/funding/manager.go
Lines 104 to 107 in 693b399
The text was updated successfully, but these errors were encountered: