discovery+lnwire: add support for DNS host name in NodeAnnouncement msg #9455

mohamedawnallah · 2025-01-29T01:48:15Z

Change Description

Closes #6337.
Closes #9126.

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

Your PR passes all CI checks.
Tests covering the positive and negative (error paths) are included.
Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
Commits follow the Ideal Git Commit Structure.
Any new logging statements use an appropriate subsystem and logging level.
Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our Contribution Guidelines for further guidance.

coderabbitai · 2025-01-29T01:48:23Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

graph/db/addr.go

sample-lnd.conf

ellemouton · 2025-02-10T06:34:03Z

lnrpc/lightning.proto

@@ -3437,6 +3437,9 @@ message LightningNode {

    // Custom node announcement tlv records.
    map<uint64, bytes> custom_records = 7;
+
+    // The DNS hostname address of the node, if available.
+    NodeAddress dns_hostname_address = 8;


why a new field for this if we already have an addresses field above?

ellemouton · 2025-02-10T06:36:29Z

cmd/commands/peersrpc_active.go

@@ -69,6 +69,10 @@ var updateNodeAnnouncementCommand = cli.Command{
 			Name:  "color",


a suggestion for PR structure: it's a better pattern to do:

add new logic internal to the server

expose new logic of server via RPC

start reading/using new logic from client

a nice way to think about it is: we always want to be able to revert back to any commit and have things make sense. But with this current order, if we reverted to this commit, we would have all these fields that the server is exposing and the client is writing to but it wont actually do anything on the server side which doesnt make sense

ellemouton · 2025-02-10T06:42:22Z

config.go

@@ -325,26 +325,28 @@ type Config struct {
 	// loadConfig function. We need to expose the 'raw' strings so the


this commit is doing way too much.

start with just lnwire (ie, "schema first" rule) and make sure to add the necessary tests around decoding/encoding there. Also, maybe i missed this but somewhere we need to check that our peers are not sending us more than 1 DNS address in their announcements (see bolt 7).

then slowly expand out from there, commit by commit to start using the new type.

each commit should be one unit of change that the reviewer needs to consider.

lightninglabs-deploy · 2025-03-03T08:24:43Z

@mohamedawnallah, remember to re-request review from reviewers when ready

alexbosworth reviewed Feb 2, 2025

View reviewed changes

graph/db/addr.go Outdated Show resolved Hide resolved

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch from 27e571d to 3e93cdf Compare February 3, 2025 13:52

lnrpc: add dns_hostname_address field

fcdd9bc

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch from 3e93cdf to cb36d26 Compare February 3, 2025 13:56

MaxFangX mentioned this pull request Feb 5, 2025

[bug]: Node announcements from peers are not re-propagated if they contain a DNS hostname #9473

Closed

saubyk reviewed Feb 5, 2025

View reviewed changes

sample-lnd.conf Outdated Show resolved Hide resolved

saubyk assigned mohamedawnallah Feb 5, 2025

saubyk added this to the v0.20.0 milestone Feb 5, 2025

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch from cb36d26 to fb721bc Compare February 5, 2025 02:59

multi: add dns_hostname_address field

4a8adcb

mohamedawnallah force-pushed the supportDNSHostnameInNodeAnnouncement branch from fb721bc to 4a8adcb Compare February 5, 2025 03:06

yyforyongyu mentioned this pull request Feb 5, 2025

graph/db: correctly handle de(ser)ialisation of models.LightningNode opaque addresses #9474

Merged

ellemouton requested changes Feb 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

discovery+lnwire: add support for DNS host name in NodeAnnouncement msg #9455

discovery+lnwire: add support for DNS host name in NodeAnnouncement msg #9455

mohamedawnallah commented Jan 29, 2025 •

edited

Loading

coderabbitai bot commented Jan 29, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

ellemouton Feb 10, 2025

ellemouton Feb 10, 2025

ellemouton Feb 10, 2025

lightninglabs-deploy commented Mar 3, 2025

		@@ -69,6 +69,10 @@ var updateNodeAnnouncementCommand = cli.Command{
		Name: "color",

		@@ -325,26 +325,28 @@ type Config struct {
		// loadConfig function. We need to expose the 'raw' strings so the

discovery+lnwire: add support for DNS host name in NodeAnnouncement msg #9455

Are you sure you want to change the base?

discovery+lnwire: add support for DNS host name in NodeAnnouncement msg #9455

Conversation

mohamedawnallah commented Jan 29, 2025 • edited Loading

Change Description

Steps to Test

Pull Request Checklist

Testing

Code Style and Documentation

coderabbitai bot commented Jan 29, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

ellemouton Feb 10, 2025

Choose a reason for hiding this comment

ellemouton Feb 10, 2025

Choose a reason for hiding this comment

ellemouton Feb 10, 2025

Choose a reason for hiding this comment

lightninglabs-deploy commented Mar 3, 2025

mohamedawnallah commented Jan 29, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)