Feat: Optimistic writes #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
todo:
|
…te APIs; add consumed offset check in receive hook
…Did; update createPost to accept createdAt parameter; add new dependency for common-web
…d when atproto comment created
…ure proper async handling; add logging for delete operations
…ions; update related types and API calls
…te createVote and related functions for improved readability and maintainability
tom-sherman
requested changes
Dec 13, 2024
| @@ -46,7 +46,7 @@ export const Post = sqliteTable( | |||
| { | |||
| id: integer("id").primaryKey(), | |||
| rkey: text("rkey").notNull(), | |||
| cid: text("cid").notNull().unique(), | |||
| cid: text("cid").notNull().default(""), | |||
There was a problem hiding this comment.
Can we not remove the non null constraint here?
There was a problem hiding this comment.
there's a hard dependency on cids for strong refs currently and if we wanna remove this and make it actually nullable it should be done in a future PR I think
| export type ApiCreateVoteInput = { | ||
| subject: { | ||
| rkey: string; | ||
| cid: string; |
There was a problem hiding this comment.
Not used, should be removed.
There was a problem hiding this comment.
it's used as a strong ref on line 41 for referencing the subject
|
|
||
| const bskyProfile = await getBlueskyProfile(user.did); | ||
|
|
||
| await sendDiscordMessage({ |
There was a problem hiding this comment.
This needs to go in the receive hook so that it's called on out-of-AppView writes also.
There was a problem hiding this comment.
I think it already is as well
… return values for post, vote, and comment retrieval, and ensuring proper async handling in delete operations
…ate logic; add checks to prevent redundant deletions and enhance error handling
… post, and comment actions; enhance validation to ensure users can only act on their own content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add optimistic writes to the solution, allowing to write to the db before ingestion and opens us up to be able to use useOptimistic()
Does this fix an issue? If so:
Fixes #207
Type of change
Please delete options that are not relevant.
Checklist:
todo:
usefor a later PRuseOptimistic()to provide optimistic state while waiting for db