Store invalid messages in dead letter queue #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
github-actions
bot
added
documentation
tom-sherman
commented
Dec 1, 2024
Comment on lines
-95
to
+90
| // TODO: This should add a dead letter | ||
| store.record_dead_letter_jetstream_error(&e)?; |
There was a problem hiding this comment.
This is the actual intended change, everything else is a refactor to enable it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a simple change but I wanted to also not leak the dlq message structure so changed the generic store function to two specific functions for storing failed commits or jetstream errors.
To do this required splitting out jetstream into it's own crate (to share the types between drainpipe and drainpipe-store). That's where the majority of the diff comes from.