Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using sftp-server found within PATH #94

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

arixmkii
Copy link
Contributor

@arixmkii arixmkii commented Mar 6, 2025

Closes lima-vm/lima#3183

Before trying list of well-known candidates allow detection routine to check if the binary is discoverable inside PATH already. This covers cases for unknown distributions or user built packages, which could be symlinked into /usr/local/bin to be discoverable before system packages and Windows, where needed dependencies might have different packaging.

Tested on Windows machine with my work in progress QEMU support branch of Lima.

Before trying list of well-known candidates allow detection routine to
check if the binary is discoverable inside PATH already. This covers
cases for unknown distributions or user built packages, which could be
symlinked into `/usr/local/bin` to be discoverable before system packages
and Windows, where needed dependencies might have different packaging.

Signed-off-by: Arthur Sengileyev <[email protected]>
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 9bed0bc into lima-vm:master Mar 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants