-
Notifications
You must be signed in to change notification settings - Fork 1
Revisit nf.explode()
for multiple columns and duplicated index
#332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 98.11% 98.13% +0.02%
==========================================
Files 18 18
Lines 1748 1774 +26
==========================================
+ Hits 1715 1741 +26
Misses 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Click here to view all benchmarks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks great! The extension to more general behavior is definitely more helpful :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks great!
I’ve actually been working on my own implementation of
NestedFrame.explode
in parallel with #327. Here I merge the two implementations but keep the test suites separate, since they cover different cases