Skip to content

Commit

Permalink
Use Node v18.18.2 LTS (Iron) (primer#681)
Browse files Browse the repository at this point in the history
* feat(node): use v18.18.2 LTS – Iron

* fix(workflow): use node version from .nvmrc

> The node-version-file input accepts a path to a file containing
> the version of Node.js to be used by a project, for example .nvmrc,
> .node-version, .tool-versions, or package.json.

https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#node-version-file

* fix(workflow): remove erroneous option
  • Loading branch information
mxdvl authored Nov 29, 2023
1 parent 2d5a368 commit 7bc4902
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 15 deletions.
10 changes: 6 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: actions/setup-node@master
- uses: actions/setup-node@v4
with:
version: 14
node-version-file: '.nvmrc'
cache: 'yarn'
- name: install
run: yarn
- name: Lint with ESLint
Expand All @@ -16,9 +17,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: actions/setup-node@master
- uses: actions/setup-node@v4
with:
version: 14
node-version-file: '.nvmrc'
cache: 'yarn'
- name: install
run: yarn
- name: Lint with markdownlint
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,11 @@ jobs:

- name: Checkout default branch
uses: actions/checkout@v2
with:
version: 16

- name: Set up Node
uses: actions/setup-node@v2
- uses: actions/setup-node@v4
with:
node-version: 16
node-version-file: '.nvmrc'
cache: 'yarn'

- name: Cache dependencies
uses: actions/cache@v2
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/deploy_preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,11 @@ jobs:

- name: Checkout default branch
uses: actions/checkout@v2
with:
version: 16

- name: Set up Node
uses: actions/setup-node@v2
- uses: actions/setup-node@v4
with:
node-version: 16
node-version-file: '.nvmrc'
cache: 'yarn'

- name: Cache dependencies
uses: actions/cache@v2
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
18.18.2

0 comments on commit 7bc4902

Please sign in to comment.