Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Pearson correlation score based feature filtering for random effects #457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove Pearson correlation score based feature filtering for random effects #457

wants to merge 1 commit into from

Conversation

ashelkovnykov
Copy link
Contributor

No description provided.

@ashelkovnykov
Copy link
Contributor Author

Updated for latest master.
@cmjiang @lguo Requesting review

Is Photon ML being published to an external artifact repository now? Which files need to be updated before a merge?

@cmjiang
Copy link
Collaborator

cmjiang commented May 9, 2020

@ashelkovnykov The migration to external artifact repo is done. Please update release-bintray.gradle for new versions and CHANGELOG.md for new changes.

@ashelkovnykov
Copy link
Contributor Author

@cmjiang
Does each change necessarily publish a new jar? What if we want to have multiple GitHub PRs condensed into one release, what should I do for that case? Asking because all five of my "ready to go" PRs should technically be a new major version, but I don't want to suddenly take us to version 25 of Photon ML. Thank you

@cmjiang
Copy link
Collaborator

cmjiang commented May 16, 2020

@ashelkovnykov Good question. We don't need to push each change to a new jar. And we definitely don't want to suddenly bump 5 major version up. However the problem is that the version is explicitly pinned in the release-bintray.gradle. I can't think of a neat solution for now. @lguo @yunboouyang Any idea?

@cmjiang
Copy link
Collaborator

cmjiang commented May 16, 2020

Since we don't have to push each change to a new jar, we can just keep the same version number for those PRs without new jars. The problem is that the same version number may have different versions of code.

ashelkovnykov
ashelkovnykov commented May 20, 2020
View reviewed changes
photon-api/src/main/scala/com/linkedin/photon/ml/data/RandomEffectDataset.scala
@@ -287,27 +286,24 @@ object RandomEffectDataset {
randomEffectDataConfiguration,
randomEffectPartitioner)
val projectedGroupedActiveData = generateProjectedActiveData(unfilteredActiveData, unfilteredProjectors)
val projectedUnfilteredActiveData = featureSelectionOnActiveData(
projectedGroupedActiveData,
randomEffectDataConfiguration.numFeaturesToSamplesRatioUpperBound)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remove the numFeaturesToSamplesRatioUpperBound from the data configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunboouyang yunboouyang yunboouyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashelkovnykov @cmjiang @yunboouyang