Fixes for the event stream model #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit db9c2da (pw_poller: poll events, not series, 2025-04-23) unintentionally removed a log opening section, while deleting some unused code. The log_open_sec() and log_end_sec() calls must be balanced. Signed-off-by: Jakub Kicinski <[email protected]>
We seem to be fetching the same series multiple times right now. This is likely because PW uses >= for time comparison and we use the date of last fetched event as the since date. Signed-off-by: Jakub Kicinski <[email protected]>
jmberg
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
That seems like a reasonable workaround.
I actually knew about this (patchwork using >=) but in the other place I'd used it that was an advantage and I didn't really think about the consequences here.
The alternative would be to keep a list of processed series at that timestamp or something, but that seems way more effort than needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jmberg couple of minor tweaks, not tested yet because we need a bit of idle time to "cut" this in :)