Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners #30

Merged
merged 1 commit into from
May 5, 2020
Merged

Add codeowners #30

merged 1 commit into from
May 5, 2020

Conversation

tyll
Copy link
Member

@tyll tyll commented May 5, 2020

Use the GitHub codeowners feature to setup default reviewers. They will
be automatically selected for new pull requests.

Use the GitHub codeowners feature to setup default reviewers. They will
be automatically selected for new pull requests.
@tyll tyll requested review from i386x, pcahyna and richm May 5, 2020 14:52
@richm
Copy link
Contributor

richm commented May 5, 2020

If individual roles want to have separate/additional reviewers, how will those be added? e.g. you will probably want to have @tyll added to network/CODEOWNERS. But then we won't be able to automatically sync future changes from template/CODEOWNERS to network/CODEOWNERS. I guess this ok - we'll have to take this into consideration in https://github.com/linux-system-roles/auto-maintenance/blob/master/sync-template.sh

@tyll
Copy link
Member Author

tyll commented May 5, 2020

My idea was not to have this file synced but to specify who will review PRs for this repository. Do you want to be asked to review each change in other system roles? It might make sense to do this maybe for all changes that affect files from the template like tox.ini, .travs/ etc. but this is not what this PR is about. :-)

@richm
Copy link
Contributor

richm commented May 5, 2020

My idea was not to have this file synced but to specify who will review PRs for this repository.

Ah, ok. I think some sort of CODEOWNERS file should be part of the template to be synced to other repositories. #31

@richm richm merged commit 4a3244b into linux-system-roles:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants