Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard applet refactoring #10671

Merged
merged 10 commits into from
Apr 12, 2022
Merged

Conversation

AxXxB
Copy link
Contributor

@AxXxB AxXxB commented Feb 15, 2022

A little more solid code, things like #9806, #8257 and #7792 should now never happen.

Also, the second commit adds a code that saves maximum width and height of applet (see #9505)

@Fantu
Copy link
Contributor

Fantu commented Feb 15, 2022

@AxXxB thanks for your contribute, the keyboard layout will change significantly with the muffin rebase, so I suppose it's best to make the improvements directly there: linuxmint/muffin#601 (see also the related changes)
he will avoid wasting time with the rebase to you and / or mtwebster and maybe if you want you could help him for that part in the rebase
for faster/easy initial test/start can be useful my ppa with the 4 components updated for the rebase: https://launchpad.net/~fantonifabio/+archive/ubuntu/muffin-rebase/

@mtwebster
Copy link
Member

Can you squash this down a bit? (Or I can merge into a single commit if you want)

Thanks

@AxXxB
Copy link
Contributor Author

AxXxB commented Apr 9, 2022

Single commit is fine =)

@mtwebster mtwebster merged commit 037b172 into linuxmint:master Apr 12, 2022
@AxXxB AxXxB deleted the keyboard-applet-refactoring branch April 13, 2022 14:32
@Fantu
Copy link
Contributor

Fantu commented May 9, 2022

hi, I did a fast test of muffin-5.2-test after a rebase including also this PR and I saw an error in logs: "Layout list is empty"
but seems applet still show layout list, I not searched deep in code but here a screenshot including also a trace that I suppose can be useful.

@mtwebster
Copy link
Member

I think I fixed it, just pushed to that pr

@Fantu
Copy link
Contributor

Fantu commented May 9, 2022

@mtwebster thanks, I did another fast test and I confirm is solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants