-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keyboard applet refactoring #10671
keyboard applet refactoring #10671
Conversation
@AxXxB thanks for your contribute, the keyboard layout will change significantly with the muffin rebase, so I suppose it's best to make the improvements directly there: linuxmint/muffin#601 (see also the related changes) |
Move all calls to gkbd into separate class in order to make it easier to replace these calls when switching to new API
Can you squash this down a bit? (Or I can merge into a single commit if you want) Thanks |
Single commit is fine =) |
hi, I did a fast test of muffin-5.2-test after a rebase including also this PR and I saw an error in logs: "Layout list is empty" |
I think I fixed it, just pushed to that pr |
@mtwebster thanks, I did another fast test and I confirm is solved |
A little more solid code, things like #9806, #8257 and #7792 should now never happen.
Also, the second commit adds a code that saves maximum width and height of applet (see #9505)