Fix visual tearing in scroll-view (#11760) #12672
Open
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't tested this so I don't know if it works but in any case, this seems like a workaround rather than fixing the actual cause. The scrolling seems to be working ok except that the area being scrolled is being miscalculated. It seems that the width of the area on the right that is not being repainted (left behind) is equal to the left padding of the child actor. In other words, the width of the repainted area is ok but is positioned to ignore the left padding of the child actor. Another thing to note is that this problem does not occur with autoscrolling (mouseover scrolling) and neither if the priv->vscrollbar_policy is set to ST_POLICY_NEVER cf. #11760 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the visual tearing issue seen when scrolling or navigating in the categories box within menu@cinnamon as described in #11760. While this approach resolves the issue, I haven't worked with Cinnamon's codebase before, so feedback on improving the implementation is welcome.