Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new GTM/GA default exclusion; Fixed typos #395

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+12 −11
Open

Added new GTM/GA default exclusion; Fixed typos #395

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c817ed
Fix excluded delayed JS so still loads
J-Rey Aug 18, 2021
23e4fbc
Typos in console & debug msgs
J-Rey Aug 18, 2021
f4d0c18
Added modern GA & GTM default exclusion
J-Rey Aug 18, 2021
b2de105
Guest Mode corrections/clarifications
J-Rey Aug 20, 2021
48f2d3a
Merge branch 'dev' into dev
J-Rey Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/js/js_delay.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/optimize.cls.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ private function _optimize() {
*/
private function _build_js_tag( $src ) {
if ( $this->cfg_js_defer === 2 ) {
return '<script data-optimized="1" type="text/javascript" src="' . $src . '"></script>';
return '<script data-optimized="1" type="litespeed/javascript" data-i="' . ++$this->i2 . '" data-src="' . $src . '"></script>';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be in your PR?

}

if ( $this->cfg_js_defer ) {
Expand Down
2 changes: 1 addition & 1 deletion tpl/general/settings_inc.guest.tpl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<td>
<?php $this->build_switch( $id ); ?>
<div class="litespeed-desc">
<?php echo __( 'Guest Mode provides an always cacheable landing page for an automated guest\'s first time visit, and then attempts to update cache varies via AJAX.', 'litespeed-cache' ); ?>
<?php echo __( 'Guest Mode provides an always cacheable initial page for a visitor\'s first time visit, and then attempts to update cache varies via AJAX.', 'litespeed-cache' ); ?>
<?php echo __( 'This option can help to correct the cache vary for certain advanced mobile or tablet visitors.', 'litespeed-cache' ); ?>
<?php Doc::learn_more( 'https://docs.litespeedtech.com/lscache/lscwp/general/#guest-mode' ); ?>
<br /><?php Doc::notice_htaccess(); ?>
Expand Down
4 changes: 2 additions & 2 deletions tpl/general/settings_tuning.tpl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
</div>

<div class="litespeed-desc">
<?php echo __( 'Listed User Agents will be considered as Guest Mode visitors.', 'litespeed-cache' ); ?>
<?php echo __( 'Listed User Agents will be considered as Guest Mode visitors every visit.', 'litespeed-cache' ); ?>
<?php Doc::one_per_line(); ?>
</div>
</td>
Expand All @@ -47,7 +47,7 @@
</div>

<div class="litespeed-desc">
<?php echo __( 'Listed IPs will be considered as Guest Mode visitors.', 'litespeed-cache' ); ?>
<?php echo __( 'Listed IPs will be considered as Guest Mode visitors every visit.', 'litespeed-cache' ); ?>
<?php Doc::one_per_line(); ?>
</div>
</td>
Expand Down