Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events): ensure callable metadata is replicated #4045

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

Harshal6927
Copy link
Contributor

Description

Closes

#4044

@Harshal6927 Harshal6927 requested review from a team as code owners March 5, 2025 03:21
@cofin cofin changed the title Fix/sync listeners fix(events): ensure callable metadata is replicated Mar 5, 2025
@Harshal6927 Harshal6927 changed the title fix(events): ensure callable metadata is replicated fix: internal server error issue when raising exception from sync callable in listeners Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.34%. Comparing base (171f98e) to head (a1480ff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4045   +/-   ##
=======================================
  Coverage   98.33%   98.34%           
=======================================
  Files         348      348           
  Lines       15824    15829    +5     
  Branches     1748     1749    +1     
=======================================
+ Hits        15561    15567    +6     
+ Misses        127      125    -2     
- Partials      136      137    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Harshal6927 Harshal6927 changed the title fix: internal server error issue when raising exception from sync callable in listeners fix(events): ensure callable metadata is replicated Mar 5, 2025
Copy link

github-actions bot commented Mar 5, 2025

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4045

Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofin cofin merged commit 28daa52 into litestar-org:main Mar 5, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants