Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[draft] feat: add AVSynchronizer #1168

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[draft] feat: add AVSynchronizer #1168

wants to merge 5 commits into from
+330 −0

Conversation

longcw
Copy link
Collaborator

@longcw longcw commented Dec 3, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 58d2f87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

davidzhao
davidzhao reviewed Dec 4, 2024
View reviewed changes
livekit-agents/livekit/agents/utils/av_sync.py Outdated Show resolved Hide resolved
livekit-agents/livekit/agents/utils/av_sync.py Outdated
)
async for video_frame, audio_frame in video_generator:
av_sync.push(video_frame)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
av_sync.push(video_frame)
await av_sync.push(video_frame)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for docs, maybe also clarify that it could be pushed from different tasks?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll create an example to test and demonstrate the use case.

livekit-agents/livekit/agents/utils/av_sync.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@longcw @davidzhao