Skip to content

Enhance Disconnect Event #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

holofermes
Copy link
Contributor

Enhance Disconnect Event with Reason Information

This PR updates the Disconnected event to include a DisconnectReason, providing more context when disconnections occur. It ensures that disconnect events fire consistently across all disconnection paths, including the DisconnectReceived callback, and not just via the room events.

  • Introduced DisconnectDelegate to handle disconnection events with a reason
  • Updated the Disconnected event to use DisconnectDelegate
  • Ensured Disconnected event fires with the appropriate reason when disconnection occurs via DisconnectReceived

Fixes #101

@holofermes holofermes marked this pull request as draft April 14, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Firing of Disconnect Events Across Disconnection Paths
1 participant