[WIP] feat: Try to enable software APM(aec,ns,agc) for rust-core. #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theomonnom
reviewed
Sep 22, 2024
webrtc-sys/src/audio_track.cpp
Outdated
| @@ -163,15 +163,15 @@ AudioTrackSource::InternalSource::InternalSource( | |||
|
|
|||
| if (buffer_.size() >= samples10ms) { | |||
| for (auto sink : sinks_) | |||
| sink->OnData(buffer_.data(), sizeof(int16_t), sample_rate_, | |||
| sink->OnData(buffer_.data(), sizeof(int16_t) * 8, sample_rate_, | |||
There was a problem hiding this comment.
funny that it works without it
There was a problem hiding this comment.
yeah, assert is only triggered in debug mode.
cloudwebrtc
force-pushed
the
duan/aec3-experimental
branch
from
e0002ae
to
c5f4726
Compare
cloudwebrtc
force-pushed
the
duan/aec3-experimental
branch
from
c5f4726
to
3cea202
Compare
cloudwebrtc
changed the title
cloudwebrtc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to adjust the calling path of (microphone capture) audioframe
Currently it is
audio frame->on_captured_frame->sinks->OnData->audio_senders->SendAudioDataAdjust to
audio frame->on_captured_frame->audio_device_buffer->SetRecordedBuffer/DeliverRecordedData->
audio_transport_cb_->RecordedDataIsAvailable->audio_senders->SendAudioDataand Playback