Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium testing #391

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Conversation

parteekcoder
Copy link

@parteekcoder parteekcoder commented Mar 12, 2023

@llaske @NikhilM98
#398
First step towards selenium testing for sugarizer-server

image

I would like your suggestions and work upon, now it is just a initial step I will refactor the code to the best possible approch

Lionel Laské and others added 4 commits February 15, 2023 22:10
@parteekcoder parteekcoder changed the base branch from master to dev March 12, 2023 04:14
@parteekcoder
Copy link
Author

also there are some eslint errors I will remove them

@parteekcoder
Copy link
Author

parteekcoder commented Mar 12, 2023

hi @llaske @NikhilM98 please guide me, I will make code more optimized but I want to know if it is to be done in the way I implemented

currently I implemented 2 tests, whose outputs are coming correct as expected
image

@parteekcoder
Copy link
Author

I know first I need to add a fakeuser to test login page , but now I just want to show what I have implemented

I will first add a fakeuser and update this PR

@parteekcoder
Copy link
Author

image

@NikhilM98
Copy link
Collaborator

Good job! This PR looks good as the first step towards selenium testing. I'll update you about the scope of the Selenium testing soon.

@parteekcoder
Copy link
Author

Good job! This PR looks good as the first step towards selenium testing. I'll update you about the scope of the Selenium testing soon.

@NikhilM98 thanks for the review, should write some more test

@parteekcoder
Copy link
Author

Good job! This PR looks good as the first step towards selenium testing. I'll update you about the scope of the Selenium testing soon.

Hey @NikhilM98 you are telling about some selenium testing scope , what is that

@NikhilM98
Copy link
Collaborator

The idea is to have functional testing to complement unit testing. The selenium tests should test the the features of each view.

For example (for Users view): testing "if the users are correctly listed in the users view", "does searching, sorting, and filtering on the users view works as expected", "does the users form successfully creates a new user", "are the details of the created user correct in the edit user view", etc.

@parteekcoder
Copy link
Author

The idea is to have functional testing to complement unit testing. The selenium tests should test the the features of each view.

For example (for Users view): testing "if the users are correctly listed in the users view", "does searching, sorting, and filtering on the users view works as expected", "does the users form successfully creates a new user", "are the details of the created user correct in the edit user view", etc.

yeah sure @NikhilM98 I will work upon this

@llaske
Copy link
Owner

llaske commented Apr 30, 2023

I've fixed a specific issue on Linux and published a branch here https://github.com/llaske/sugarizer-server/tree/feature/selenium

@parteekcoder
Copy link
Author

parteekcoder commented May 1, 2023

I've fixed a specific issue on Linux and published a branch here https://github.com/llaske/sugarizer-server/tree/feature/selenium

Thanks @llaske , please may I know the issue on Linux. So that in Future I also consider that while making PR

@parteekcoder
Copy link
Author

@llaske I checked that branch and understood the issue. Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants