Skip to content

Commit

Permalink
[Python] Remove dependency on MLIRPythonSources.Dialects.builtin.
Browse files Browse the repository at this point in the history
This specific dependency no longer works after an upstream change:
llvm/llvm-project#97167. Furthermore, we never
actually wanted this dependency, since we don't actually do anything
with the builtin dialect ops. We only used this to convince the MLIR
bindings to do the automatic downcasting for builtin dialect types and
attributes, which required the builtin dialect to be registered (even
though it always is) until this change went in:
llvm/llvm-project#72338. Now that these
changes are behind us, we can remove our workaround and avoid the
issues that ensue by depending on a target no one usually depends on.
  • Loading branch information
mikeurbach committed Jul 20, 2024
1 parent 6eff7ed commit 0102a61
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/Bindings/Python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ add_mlir_python_modules(CIRCTPythonModules
INSTALL_PREFIX "python_packages/circt_core/circt"
DECLARED_SOURCES
MLIRPythonSources.Core
MLIRPythonSources.Dialects.builtin
CIRCTBindingsPythonExtension
CIRCTBindingsPythonSources
COMMON_CAPI_LINK_LIBS
Expand Down

0 comments on commit 0102a61

Please sign in to comment.