[TOSA] Add TosaLayerwiseConstantFoldPass and TosaReduceTransposes passes #4165
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the following passes to TorchBackendToTosaBackendPipeline: - TosaLayerwiseConstantFoldPass: fold full-layer operations on TOSA consts - TosaReduceTransposes: remove unnecessary TOSA transposes to reduce data movements Signed-off-by: Justin Ngo <[email protected]> Change-Id: I44636a7392a571e57c2c3a2c0316835d2d2ca938
sahas3
reviewed
Apr 25, 2025
| # File "torch-mlir/build/tools/torch-mlir/python_packages/torch_mlir/torch_mlir_e2e_test/framework.py", line 316, in handle_timeout | ||
| # raise TimeoutError(self.error_message) | ||
| # TimeoutError: Timeout | ||
| "BertModule_basic", |
There was a problem hiding this comment.
It's possible to specify a timeout value like
but I don't know if it's possible to increase the value only toTosa conversion path.
There was a problem hiding this comment.
I don't think it's a good idea to increase the timeout for all conversion paths. Right now, the BertModule test is marked as XFail any way, so maybe it can be fixed altogether later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following passes to TorchBackendToTosaBackendPipeline: