Thank you, Mr. Cornet! #5
Conversation
- *Removed* extension browser action + Now runs automatically every time a new tab is opened.
trigger on tab creation, not clicking extension button
See additional tab events: https://developer.chrome.com/extensions/tabs Omitting onAtached event. Goal is to replicate ChromeOS behavior.
_Removed_ Detached trigger.
Preparing for pull request
|
Thank you so much for writing this!! I do think it is an improvement, at least for my own use case. I do want to give users the option of retaining the current behavior, though... Maybe with a setting? Or, make the extension button a toggle: press it to turn it on (and then we get the behavior with your modifications), press it again to turn if off and be able to manage your own windows. What do you think? Thanks again for spending time on this! |
|
Hi Imanul, is this waiting to have your suggestions implemented. Is it okay if I take a crack at it? |
|
Hi @dnecklesportfolio yes of course! Since this has been open for more than six months, I would assume that @jcarroll won't mind either? Thanks for offering!! I'm hoping there's a way for you to add your contributions while James still gets credited for his? |
Thank you so much for making window-tiler open source!
This pull request removes the need to click on the extension button; instead, it triggers on chrome.tabs.onCreated and tabs.onRemoved.
If you think it's an improvement, will you please publish it to the chrome web store?