Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RF devices on machine shutdown script #169

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update RF devices on machine shutdown script #169

wants to merge 1 commit into from

Conversation

murilobalves
Copy link
Contributor

@murilobalves murilobalves commented Sep 30, 2024 •
edited
Loading

TODO:

  • Update ID devices creation with new/removed IDs from the machine

anacso17
anacso17 reviewed Oct 21, 2024
View reviewed changes
bin/sirius-script-procedures-machine-shutdown.py
Comment on lines +533 to +534
for cavmon in cavmons:
if not self._wait_devices_propty(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @murilobalves , in this case it seems we don't need the loop here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anacso17 anacso17 anacso17 left review comments

@xresende xresende Awaiting requested review from xresende

@fernandohds564 fernandohds564 Awaiting requested review from fernandohds564

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murilobalves @anacso17