Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

โœจ feat: Update the display_override property of the Manifest class to 'window-controls-overlay', adapt to the windows-side pwa hidden top bar #7071

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nbb2025
Copy link

@nbb2025 nbb2025 commented Mar 21, 2025

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

Updated the display_override property of the Manifest class to 'window-controls-overlay', enabling the PWA application on Windows platform to adapt to the hidden top bar feature. This allows the application to gain more usable space and provide a more native-like experience.

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

Window Controls Overlay (WCO) is a PWA feature that allows web applications installed on desktop platforms to utilize the title bar area of the application window. This provides more screen real estate for your application by moving the system window controls (minimize, maximize, close buttons) to a small overlay instead of occupying the entire title bar.
This feature is supported in Chromium-based browsers (Chrome, Edge, etc.) version 98 and later. It's not supported in Firefox or Safari as of now.

Copy link

vercel bot commented Mar 21, 2025

@nbb2025 is attempting to deploy a commit to the LobeChat Desktop Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 21, 2025
@lobehubbot
Copy link
Member

๐Ÿ‘ @nbb2025

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@dosubot dosubot bot added the ๐ŸŒ  Feature Request New feature or request | ็‰นๆ€งไธŽๅปบ่ฎฎ label Mar 21, 2025
Copy link
Contributor

gru-agent bot commented Mar 21, 2025

TestGru Assignment

Summary

Link CommitId Status Reason
Detail 9fb5317 ๐Ÿšซ Skipped

Files

File Pull Request
src/server/manifest.ts ๐Ÿšซ Skipped (There's no need to update the test code)

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

Copy link

vercel bot commented Mar 23, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-preview โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Mar 23, 2025 10:51am

Copy link

codecov bot commented Mar 23, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 91.39%. Comparing base (03c95ab) to head (9fb5317).
Report is 34 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7071   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files         741      741           
  Lines       70126    70126           
  Branches     4807     4805    -2     
=======================================
  Hits        64095    64095           
  Misses       6031     6031           
Flag Coverage ฮ”
app 91.39% <100.00%> (รธ)
server 97.54% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐ŸŒ  Feature Request New feature or request | ็‰นๆ€งไธŽๅปบ่ฎฎ size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants