[WIP] Kamal deployment #1192
[WIP] Kamal deployment #1192
Conversation
Add Kamal deployment configuration with support for PostgreSQL, SQLite, and background queue workers. Includes deployment templates for Docker, secrets management, and deployment configuration.
| sqlite: bool, | ||
| postgres: bool, | ||
| background_queue: bool, |
There was a problem hiding this comment.
I believe that none of the parameters (fallback_file, asset_folder, host, port) and also the new params are strictly necessary.
The deployment function should take a reference to &Config (you already have the config in cli.rs), and each deployment type should be able to utilize the configuration that works best for it.
There was a problem hiding this comment.
@kaplanelad I was trying to use &loco-rs::config::Config in loco gen project. However, importing loco-rs within loco-gen will cause cyclic dependency
| @@ -0,0 +1,47 @@ | |||
| to: "Dockerfile" | |||
There was a problem hiding this comment.
Why are we not using the same docker template that we already have?
I don't think we need to hold two docker templates
There was a problem hiding this comment.
The current docker template has a different purpose than the one kamal one. As I can see the current dockerfile does not include sea orm and seems to be just compiling the binaries without running it. Not sure if I merge them or leave them separated.
There was a problem hiding this comment.
The question is, why should SeaORM be included in this docker file.
There was a problem hiding this comment.
We are using sea-orm-cli for generating entities. Why would you need to generate entities inside the Dockerfile?
There was a problem hiding this comment.
My current dockerfile for kamal setup is serving the server within the container instead of just compiling, which requires database connection like sqlite or postgres. Therefore SeaOrm is kinda required?
There was a problem hiding this comment.
Wait sea orm cli is not required for database connection? Okay I will remove it
There was a problem hiding this comment.
Please check if you can use the current docker file and not create a new one
# Conflicts: # src/cli.rs
cargo loco generate deployment --kind kamalcommandconfig/deploy.yml,.kamal/secretsandDockerfilefor both sqlite and postgresql + redis.development.yamlto open0.0.0.0bindings.config/deploy.yml,.kamal/secretsandDockerfile.