Bump RestClient gem (Dinda-com-br#17)

locomotivapro · Dec 14, 2016 · eee6704 · eee6704
1 parent eff541c
commit eee6704
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/braspag-rest.gemspec b/braspag-rest.gemspec
@@ -17,12 +17,13 @@ Gem::Specification.new do |spec|
   spec.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rest-client", "~> 1.8"
+  spec.add_dependency "rest-client", "~> 2.0"
   spec.add_dependency "hashie", "~> 3.4"
 
   spec.add_development_dependency "bundler", "~> 1.10"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "pry-nav"
+  spec.add_development_dependency "pry-byebug"
 end
diff --git a/lib/braspag-rest/request.rb b/lib/braspag-rest/request.rb
@@ -68,7 +68,9 @@ def execute_braspag_request(&block)
 
         BraspagRest::Response.new(gateway_response)
       rescue RestClient::ResourceNotFound => e
-        config.logger.error("[BraspagRest][Error] message: #{e.message}, status: #{e.http_code}, body: #{e.http_body.inspect}") if config.log_enabled?
+        # Explicitly message due to Rest Client RestClient::NotFound normalization:
+        # https://github.com/rest-client/rest-client/blob/v2.0.0/lib/restclient/exceptions.rb#L90
+        config.logger.error("[BraspagRest][Error] message: Resource Not Found, status: #{e.http_code}, body: #{e.http_body.inspect}") if config.log_enabled?
         raise
       rescue RestClient::RequestTimeout => e
         config.logger.error("[BraspagRest][Timeout] message: #{e.message}") if config.log_enabled?

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -1,2 +1,4 @@
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 require 'braspag-rest'
+require 'json'
+require 'pry-byebug'