Add support for arguments when declaring an exchange #89
Conversation
|
CI failure is due to dependency to another pull request on logstash-mixin-rabbitmq_connection project |
|
CLA failed, which is probably why nobody's reviewed this yet. Please see this comment for what to do --- specifically, the email you use in the git commits must be the same email as you signed for the CLA, and I do not see the email used in your commit in our CLA database. |
|
@balooka Let me know if you have any questions about how to resolve the CLA issue. :) |
|
Hi @jordansissel , |
|
@balooka it appears you created these commits with your @staff.voo.be email address. Can you please sign the CLA with this one as well? After that, we should be good to go to move into the review stage. |
|
@acchen97 signed with additional mail. Thanks for spotting the issue and sorry for the confusion. |
| @@ -155,6 +155,10 @@ class RabbitMQ < LogStash::Inputs::Threadable | |||
| # to declare the exchange if it does not exist. | |||
| config :exchange_type, :validate => :string | |||
|
|
|||
| # Additional arguments for exchange creation, | |||
| # for example, alternate-exchange | |||
| config :exchange_arguments, :validate => :array, :default => {} | |||
There was a problem hiding this comment.
Consistency problem: You called this arguments in the output, but exchange_arguments here.
Also, same comments as in the output -- this is validate array but your default is a hash. Further, the docs aren't helpful enough, in my opinion.
Original pull request dates, making sure we take the comments into account based on latest version
|
@jordansissel @balooka Any updates to this PR? I am willing to help out with this PR if you don't have the time |
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/