Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the note paper responsive #9

Closed
wants to merge 3 commits into from
Closed

made the note paper responsive #9

wants to merge 3 commits into from

Conversation

anugcodes
Copy link
Contributor

@anugcodes anugcodes commented Mar 16, 2023

tried to make note paper responsive.
issue #8
the note paper is now responsive. @lokeshvasnik take a look.

@vercel
Copy link

vercel bot commented Mar 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
modern-notes ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 17, 2023 at 0:49AM (UTC)

@lokeshvasnik
Copy link
Owner

The responsive part is alright but @anugcodes there is

an issue with the lines the words are not sticking with the line check out the screenshot rest of everything looks good👍️
Current Pull Request

Screenshot from 2023-03-17 16-42-33

Previous

Screenshot from 2023-03-17 16-43-21

@anugcodes
Copy link
Contributor Author

@lokeshvasnik , yes you are right but working on it will not be usefull as in the previous implementation this was the issue
if you write more thant 2 to 3 lines the height was fixed and also overflow is hidden . and if you increase size of textarea the text do stick to lines again
here take a look.
editor2
editor3
editor1

so as the editor page is a import part of the project so i suggest we use some editor library for react like "react-quill" to handle this.
what do you say?

@lokeshvasnik
Copy link
Owner

Go for it. I checked the library I think this will solve the issue

@anugcodes anugcodes closed this by deleting the head repository Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants