Support multi-ecosystem derivation and sui addresses #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashxtree
reviewed
Feb 14, 2025
| // | ||
| // taggedHash( AuxData || EvmTag || ChainId || LBTCAddress || WalletAddress ) | ||
| // taggedHash( AuxData || ChainId || LBTCAddress || WalletAddress ) |
There was a problem hiding this comment.
- by the fact the byte is still there
- mb
LChainIdis better to show that it's something custom
Suggested change
| // taggedHash( AuxData || ChainId || LBTCAddress || WalletAddress ) | |
| // taggedHash( AuxData || DeprecatedChainTag || LChainId || LBTCAddress || WalletAddress ) |
| // - 'wallet' is the EVM address that will claim this deposit | ||
| // - 'chainId' is the chain id for the target EVM chain | ||
| func EvmDepositSegwitPubkey(pk *PublicKey, lbtcContract, wallet Address, chainId, auxData []byte) (*PublicKey, error) { | ||
| // - 'lbtcContract' is the address of the LBTC contract or object on the destination chain |
There was a problem hiding this comment.
Suggested change
| // - 'lbtcContract' is the address of the LBTC contract or object on the destination chain | |
| // - 'lbtcContract' is the address of the LBTC contract (EVM) or object (SUI) on the destination chain |
hashxtree
reviewed
Feb 14, 2025
Comment on lines
+310
to
+312
| // just an initial seed to generate constant data for all tests | ||
| hashVal := sha256.Sum256([]byte("segwit_lombard_tweak_test_rs")) | ||
| pk := secp256k1.PrivKeyFromBytes(hashVal[:]).PubKey() |
There was a problem hiding this comment.
shouldn't you read this public key from referenceValues (e.g., from the rootDepositKey field) so that the reference values are self-contained?
There was a problem hiding this comment.
@russanto @hashxtree any thoughts here? Thanks so much!
mlfbrown
reviewed
Feb 23, 2025
There was a problem hiding this comment.
Hey @hashxtree, are you guys going to merge this? We're currently using values from here to test our address generation and want to make sure the values/spec won't change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features
TODOs