Skip to content

Commit

Permalink
phpunit: fixup when user->id is a string
Browse files Browse the repository at this point in the history
FIXME: should we clean up and force a proper (int) ?
  • Loading branch information
xlii-chl committed Apr 29, 2022
1 parent ad15eec commit c086937
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tests/authentication/AuthenticationBaseTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ public function testLoginSuccessNoRemember()
'success' => 1,
]);

$this->assertSame(4, $_SESSION['logged_in']);
// TODO: some BDD send back strings : should we forcefullyconvert in Authentication\AuthenticationBase::login() ?
//$this->assertSame(4, $_SESSION['logged_in']);
$this->assertContains($_SESSION['logged_in'], [4, '4']);

$this->dontSeeInDatabase('auth_tokens', [
'user_id' => $user->id,
Expand Down

0 comments on commit c086937

Please sign in to comment.