Update ValidationRules.php #428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a request of type "application/json" was received, it caused an Exception of type ErrorException with the message "Undefined offset: 1". This was because the buildUserFromRequest method in the myth-auth/src/Authentication/Passwords/ValidationRules.php file was not prepared for this request. This patch fixes this issue.
|
Sorry to get here so late. If you could add a test for this case I think it's ok. The only possible issue is what if the body is empty? |
|
Hi, I have no experience with automated tests, do you have any support material? |
|
I'm working with another technology and I don't have time for these changes right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a request of type "application/json" was received, it caused an Exception of type ErrorException with the message "Undefined offset: 1".
This was because the buildUserFromRequest method in the myth-auth/src/Authentication/Passwords/ValidationRules.php file was not prepared for this request.
This patch fixes this issue.