Add blockatlas GetValidators RPC endpoints #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atchapcyp
changed the title
pathornteng
suggested changes
Sep 12, 2019
coins.yml
Outdated
| handle: loom | ||
| name: Loom | ||
| decimal: 18 | ||
| blockTime: 1000 |
go.mod
Outdated
| @@ -9,16 +9,16 @@ require ( | |||
| github.com/go-redis/redis v6.15.2+incompatible | |||
| github.com/mitchellh/mapstructure v1.1.2 | |||
| github.com/mr-tron/base58 v1.1.2 | |||
| github.com/onsi/ginkgo v1.8.0 // indirect | |||
| github.com/onsi/gomega v1.5.0 // indirect | |||
There was a problem hiding this comment.
Why are these removed? If it is not necessary, I think we should not change their go.mod.
go.sum
Outdated
| github.com/onsi/ginkgo v1.10.1 h1:q/mM8GF/n0shIN8SaAZ0V+jnLPzen6WIVZdiwrRlMlo= | ||
| github.com/onsi/ginkgo v1.10.1/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE= | ||
| github.com/onsi/gomega v1.7.0 h1:XPnZz8VVBHjVsy1vzJmRwIcSwiUO+JFfrv/xGiigmME= | ||
| github.com/onsi/gomega v1.7.0/go.mod h1:ex+gbHU/CVuBBDIJjb2X0qEXbFg53c61hWP/1CpauHY= |
platform/binance/api_test.go
Outdated
| @@ -176,7 +177,7 @@ var tokenDst = blockatlas.Token{ | |||
| Name: "Aeron", | |||
| Symbol: "ARN", | |||
| Decimals: 8, | |||
| TokenId: "ARN-71B", | |||
| TokenID: "ARN-71B", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To provide staking data to
trustwallet/blockatlas.This PR is step 3 in implementation.
We need to provide these RPC method in
loomchainGetValidatorsto get validators information.GetRateto get Annual percentage rate.//Staking Loom has fix annual interests rate.
...
ref: https://developer.trustwallet.com/staking#step-3-define-rpc-endpoints-for-blockatlas
ref 2: loomnetwork/loomchain#1461