FIX-18 : fix issue #18 - about cron with multiple hours

[DaaN88]

Check it out please! I quickly ran, everything seems to work and the error with this cron is gone :-)

[lorisleiva]

Hi there 👋

Sorry about the delay! Would you mind adding some tests to make sure the added logic create sentences that make sense? 🙂

[DaaN88]

Hello! :-)
There is no point in adding tests now, because my fix only partially solves the problem. At this point, you need to think about regular code breakouts. The bottom line is that cron will be valid if you transfer as many periods as you like in a block for hours, days, etc. That is, my fix works fine if there are two periods, but if you pass three or more, then again a parsing error ... And here's how to write a regular season to take into account an unlimited number of periods, I have not figured out yet.

[DaaN88]

That is, the crons of the form * / 15 0-8,21-23 * * * or * / 15 1 2-3,3-4 * * are now recognized correctly (in my PR).
But the crons of the form * / 15 0-8,21-23.3-4 * * * or * / 15 1 2-3,3-4,5-8 * *, well, and more periods (separated by commas) will cause a parsing error

[DaaN88]

if in this regular expression / ^ ([0-9] +) \ - ([0-9] +), ([0-9] +) \ - ([0-9] +) $ / add another block separated by commas ([0-9] +) \ - ([0-9] +), then three periods will be processed correctly. But there can be a lot of periods, as I already wrote. How many such blocks are needed? in fact, this regular expression should be modified to search for all periods listed with commas ...

[lorisleiva]

Got it! Yeah we need a more clever regex or a more clever parsed that keeps track of operator precedence.

I'll close this for now as it does not fix the issue at hand but feel free to try again on another PR. 🙂