Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transmission #1029

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Transmission #1029

wants to merge 2 commits into from

Conversation

HlubyLuk
Copy link
Contributor

@HlubyLuk HlubyLuk commented Jul 8, 2017

Add alternative configs path

@julienbourdeau
Copy link

Can you explain the difference between those 2 paths?

/usr/local/var/transmission/blocklists
~/../../usr/local/var/transmission/blocklists

They probably go the the same directory or file but I think it's always best to use the absolute path.

@HlubyLuk
Copy link
Contributor Author

Problem was mackup do not working with absolut path

trace

Traceback (most recent call last):
  File "/usr/local/bin/mackup", line 11, in <module>
    load_entry_point('mackup', 'console_scripts', 'mackup')()
  File "/Users/HlubyLuk/Workspace/python/mackup/mackup/main.py", line 65, in main
    app_db = ApplicationsDatabase()
  File "/Users/HlubyLuk/Workspace/python/mackup/mackup/appsdb.py", line 53, in __init__
    .format(path))
ValueError: Unsupported absolute path: /usr/local/var/transmission/blocklists

Copy link
Contributor

@MadeOfMagicAndWires MadeOfMagicAndWires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add system files. Sync user-specfic configuration files only.

A normal user running mackup won't be able to restore these from a backup, and presumably the user-specific overwrite the system files anyway.

Also please revert the changes to .gitignore and don't forget to add your changes to the CHANGELOG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants