Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

90 make path alignment straight between nodes #91

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

egenerse
Copy link
Collaborator

Checklist

  • I linked PR with a related issue
  • I added multiple screenshots/screencasts of my UI changes

Motivation and Context

User should be able to have straight lines in paths
This PR completes #90

Description

Everything is calculated by 10s and 5s so that the user can align any node by moving and resizing.

Steps for Testing

  1. Create a path between 2 nodes
  2. Edit nodes or move them around
  3. Try to make a straight line again
  4. If there is still some break in line, try to resize one of the nodes and it should be aligned

Screenshots

Screen.Recording.2025-01-28.at.20.35.54.mov

@egenerse egenerse requested a review from kurunbelemir January 28, 2025 19:39
@egenerse egenerse self-assigned this Jan 28, 2025
@egenerse egenerse linked an issue Jan 28, 2025 that may be closed by this pull request
Copy link
Collaborator

@kurunbelemir kurunbelemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really liked the changes. Good work

@egenerse egenerse merged commit f80daf9 into main Feb 3, 2025
2 checks passed
@egenerse egenerse deleted the 90-make-path-alignment-straight-between-nodes branch February 3, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make path alignment straight between nodes
2 participants