Assessment: Remove duplicate message and center table

[laxerhd]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Client

• I strictly followed the client coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

A duplicate message was displayed and the table was not centered.
Closes #10017.

Description

Removed the <h6> element where the duplicate message was shown.
Added mx-auto class to the table for centering.

Steps for Testing

Prerequisites:

• 1 Instructor
• 1 Course
• Add a grading key and exercise

1. Log in to Artemis
2. Navigate to the Course
3. Navigate to Statistics
4. Click View Grading Key or View Bonus Rules
5. Make sure the message is only being shown once and the table is centered

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Exam Mode Test

• Test 1
• Test 2

Performance Tests

• Test 1
• Test 2

Screenshots

Summary by CodeRabbit

• New Features
  • Updated the grading key overview layout for improved visibility and centering of the table.
• Bug Fixes
  • Removed unnecessary header display based on exam state to streamline user experience.

[coderabbitai]

Walkthrough

The pull request modifies the HTML template for the grading key overview component. The changes include removing a conditional header and updating the table's CSS class to center the table horizontally. The modification addresses a display issue in the course statistics view, specifically focusing on improving the layout and removing duplicate information for students viewing bonus rules.

Changes

File	Change Summary
src/main/webapp/app/grading-system/grading-key-overview/grading-key/grading-key-table.component.html	- Removed conditional header <h6 jhiTranslate="artemisApp.gradingSystem.overview.info"></h6> - Updated table class from table table-striped w-auto to table table-striped w-auto mx-auto to center the table

Assessment against linked issues

Objective	Addressed	Explanation
Remove duplicated info text	✅
Fix squished view in statistics	✅
Improve horizontal space usage	✅

Possibly related PRs

• Exam mode: Remove exercise title from solution containers  #9442: HTML template modifications for exam submissions with similar conditional rendering
• Communication: Correctly align manage button in communications menu #9636: Layout and alignment adjustments in communications menu

Suggested labels

client, bugfix, ready for review

Suggested reviewers

• SimonEntholzer
• florian-glombik
• rabeatwork
• krusche

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d0a9e9 and be347b2.

📒 Files selected for processing (1)

• src/main/webapp/app/grading-system/grading-key-overview/grading-key/grading-key-table.component.html (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/main/webapp/app/grading-system/grading-key-overview/grading-key/grading-key-table.component.html (1)

Pattern src/main/webapp/**/*.html: @if and @for are new and valid Angular syntax replacing *ngIf and *ngFor. They should always be used over the old style.

🔇 Additional comments (2)

src/main/webapp/app/grading-system/grading-key-overview/grading-key/grading-key-table.component.html (2)

3-3: LGTM: Table centering implemented correctly

The addition of mx-auto class is the proper way to center the table horizontally using Bootstrap utilities.

---

Line range hint 9-57: LGTM: Proper usage of new Angular control flow syntax

The template correctly uses the new @if and @for syntax throughout, following the latest Angular guidelines. This includes:

• Conditional rendering with @if for grade checks
• List iteration with @for including proper tracking

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

[laxerhd]

Hello @maximiliansoelch, this is the PR for your problem #10017. It is very short and I would be very happy if you could give your review. Thank you very much ;D

[HawKhiem]

Tested on TS3. Works as described

[ItsaaaMeMario]

Tested on TS4, works as described.

[alekspetrov9e]

Tested on TS4. Works accordingly.

[BBesrour]

code

[Haoyuli2002]

Tested on TS3, after navigating to the grading keys under Statistics, the message is only being shown once and the table is centered. Working as expected and looks good to me.

[SindiBuklaji]

Tested on Ts2. It works as described 👍