-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Reduce coverage ratios to fix failing checks
#10239
Conversation
WalkthroughThis pull request involves adjustments to code coverage thresholds in two configuration files. The changes include a decrease in the "INSTRUCTION" coverage threshold for the "iris" module in Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (7)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
jest.config.js (1)
94-97
: LGTM! Consider tracking the TODO comment.The minimal reductions in coverage thresholds align with the PR objective to fix failing pipelines. However, the TODO comment suggests these are temporary reductions that should increase to 90% in the future.
Would you like me to create an issue to track increasing these coverage thresholds to 90% in the future?
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
gradle/jacoco.gradle
(1 hunks)jest.config.js
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Call Build Workflow / Build and Push Docker Image
- GitHub Check: Call Build Workflow / Build .war artifact
- GitHub Check: client-tests
- GitHub Check: server-tests
- GitHub Check: server-style
- GitHub Check: Analyse
🔇 Additional comments (1)
gradle/jacoco.gradle (1)
45-45
: LGTM! Coverage threshold reduction aligns with PR objectives.The minimal reduction in the instruction coverage threshold for the "iris" module is consistent with the overall goal of fixing failing pipelines.
Development
: Reduce coverage ratios to fix failing pipelineDevelopment
: Reduce coverage ratios to fix failing GitHub checks
Development
: Reduce coverage ratios to fix failing GitHub checksDevelopment
: Reduce coverage ratios to fix failing checks
Checklist
General
Motivation and Context
#10209 decreased the coverage due to missing tests that will be added in a follow-up PR.
Description
Lower the client and server coverage ratios to make pipeline pass.
Steps for Testing
not needed
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Summary by CodeRabbit