Development: Add theming and color usage guidelines
#5116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
client
JohannesStoehr
previously requested changes
May 18, 2022
b-fein
reviewed
May 18, 2022
ge65cer
previously approved these changes
Jun 2, 2022
JohannesStoehr
previously approved these changes
Jun 3, 2022
Co-authored-by: Lucas Welscher <[email protected]>
bassner
requested review from
Strohgelaender,
maximiliansoelch,
JohannesStoehr and
ge65cer
Strohgelaender
previously approved these changes
Jun 5, 2022
maximiliansoelch
previously approved these changes
Jun 6, 2022
bassner
dismissed stale reviews from maximiliansoelch and Strohgelaender
via
8548e33
|
Just merged develop, which didn't affect my changes and thus we can consider the previous approvals to still count |
krusche
changed the title
Development: Add theming and color usage guidelinesDevelopment: Add theming and color usage guidelines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Motivation and Context
#4974 introduced light and dark mode to Artemis.
During development, all developers have to keep in mind that UI changes should look good in both themes; additionally, we aim to avoid the usage of too many custom colors in the future.
Description
Review Progress
Code Review