Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: link pr in the env view #540

Merged
merged 6 commits into from
Mar 17, 2025
Merged

Conversation

gbanu
Copy link
Contributor

@gbanu gbanu commented Mar 15, 2025

I didn't want to overload the environment list component even more that's why added a link to the existing latest deployment tag.

Screen.Recording.2025-03-15.at.17.29.34.mov

fixes #317

Copy link

codacy-production bot commented Mar 15, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.96% (target: -1.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f26f0a9) 4153 470 11.32%
Head commit (516c4da) 5138 (+985) 631 (+161) 12.28% (+0.96%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#540) 13 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@gbanu gbanu marked this pull request as ready for review March 15, 2025 16:38
@gbanu gbanu requested a review from a team as a code owner March 15, 2025 16:38
@gbanu gbanu temporarily deployed to test-server-1 March 15, 2025 16:50 — with GitHub Actions Inactive
@gbanu gbanu deployed to test-server-1 March 15, 2025 16:53 — with GitHub Actions Active
Copy link
Member

@egekocabas egekocabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the current behavior isn't ideal for user experience. From a user's perspective, clicking on the branch name should navigate directly to the branch details. One potential solution might be to introduce an additional tag showing only the PR number (e.g., #10254). However, in any case, we should also include a hover effect to clarify that the element is clickable and redirects the user elsewhere.

What do you think about that? I know there are already a lot of elements in this view, but I believe this approach would provide a better overall user experience.

@gbanu gbanu force-pushed the feat/link-pr-in-the-env-view branch from 30d792b to 3284f38 Compare March 16, 2025 16:15
@github-actions github-actions bot added size:L and removed size:M labels Mar 16, 2025
@gbanu
Copy link
Contributor Author

gbanu commented Mar 16, 2025

@egekocabas added a separate tag for PR and disabled navigation for release tags, Paul has implemented the release sync from github and we can implement a link to the release once his pr is merged.

Screen.Recording.2025-03-16.at.17.23.40.mov

@TurkerKoc
Copy link
Member

@egekocabas added a separate tag for PR and disabled navigation for release tags, Paul has implemented the release sync from github and we can implement a link to the release once his pr is merged.

Screen.Recording.2025-03-16.at.17.23.40.mov

That looks great thanks for adding separate link for PRs!

Maybe a minor change: I think we don't need to write PR as a prefix since this is a known pattern for developers -> #<PR_NUMBER>. Also we have the icon as well :)

Copy link
Contributor

@thielpa thielpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean! I just have a minor change, that we should address :) 🥳

@gbanu gbanu requested review from egekocabas and thielpa March 17, 2025 17:59
@gbanu gbanu force-pushed the feat/link-pr-in-the-env-view branch from edeb523 to 516c4da Compare March 17, 2025 18:06
Copy link
Member

@TurkerKoc TurkerKoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job, thanks for adding this feature 🚀 🎊

@TurkerKoc TurkerKoc merged commit 573b5a1 into staging Mar 17, 2025
20 checks passed
@TurkerKoc TurkerKoc deleted the feat/link-pr-in-the-env-view branch March 17, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Link Pull Request View in Environment View Tabs are not updating on route change
4 participants