Create activity endpoint for bad practice detection

server/application-server/openapi.yaml

@@ -351,6 +351,47 @@ paths:
             application/json:
               schema:
                 $ref: "#/components/schemas/LeagueChange"
+  /activity/user/{login}/badpractices:
+    post:
+      tags:
+      - activity
+      operationId: detectBadPracticesByUser
+      parameters:
+      - name: login
+        in: path
+        required: true
+        schema:
+          type: string
+      responses:
+        "200":
+          description: OK
+          content:
+            application/json:
+              schema:
+                type: array
+                items:
+                  $ref: "#/components/schemas/PullRequestBadPractice"
+  /activity/pullrequest/{pullRequestId}/badpractices:
+    post:
+      tags:
+      - activity
+      operationId: detectBadPracticesForPullRequest
+      parameters:
+      - name: pullRequestId
+        in: path
+        required: true
+        schema:
+          type: integer
+          format: int64
+      responses:
+        "200":
+          description: OK
+          content:
+            application/json:
+              schema:
+                type: array
+                items:
+                  $ref: "#/components/schemas/PullRequestBadPractice"
   /workspace/users:
     get:
       tags:
@@ -449,6 +490,24 @@ paths:
             application/json:
               schema:
                 $ref: "#/components/schemas/Session"
+  /activity/{login}:
+    get:
+      tags:
+      - activity
+      operationId: getActivityByUser
+      parameters:
+      - name: login
+        in: path
+        required: true
+        schema:
+          type: string
+      responses:
+        "200":
+          description: OK
+          content:
+            application/json:
+              schema:
+                $ref: "#/components/schemas/Activity"
   /workspace/team/{teamId}:
     delete:
       tags:
@@ -660,6 +719,57 @@ components:
       - name
       - teams
       - url
+    PullRequestWithBadPractices:
+      type: object
+      properties:
+        id:
+          type: integer
+          format: int64
+        number:
+          type: integer
+          format: int32
+        title:
+          type: string
+        state:
+          type: string
+          enum:
+          - OPEN
+          - CLOSED
+        isDraft:
+          type: boolean
+        isMerged:
+          type: boolean
+        labels:
+          type: array
+          items:
+            $ref: "#/components/schemas/LabelInfo"
+        repository:
+          $ref: "#/components/schemas/RepositoryInfo"
+        additions:
+          type: integer
+          format: int32
+        deletions:
+          type: integer
+          format: int32
+        htmlUrl:
+          type: string
+        createdAt:
+          type: string
+          format: date-time
+        badPractices:
+          type: array
+          items:
+            $ref: "#/components/schemas/PullRequestBadPractice"
+      required:
+      - additions
+      - deletions
+      - htmlUrl
+      - id
+      - isDraft
+      - isMerged
+      - number
+      - state
+      - title
     PullRequestBaseInfo:
       type: object
       properties:
@@ -715,6 +825,15 @@ components:
       - id
       - login
       - name
+    Activity:
+      type: object
+      properties:
+        pullRequests:
+          type: array
+          items:
+            $ref: "#/components/schemas/PullRequestWithBadPractices"
+      required:
+      - pullRequests
     UserInfo:
       type: object
       properties:
@@ -764,6 +883,15 @@ components:
       - labels
       - name
       - repositories
+    PullRequestBadPractice:
+      type: object
+      properties:
+        title:
+          type: string
+        description:
+          type: string
+        resolved:
+          type: boolean
     LeagueChange:
       type: object
       properties:

server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/ActivityController.java

@@ -0,0 +1,36 @@
+package de.tum.in.www1.hephaestus.activity;
+
+import de.tum.in.www1.hephaestus.activity.model.ActivityDTO;
+import de.tum.in.www1.hephaestus.activity.model.PullRequestBadPracticeDTO;
+import java.util.List;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.http.ResponseEntity;
+import org.springframework.web.bind.annotation.*;
+
+@RestController
+@RequestMapping("/activity")
+public class ActivityController {
+
+    @Autowired
+    private ActivityService activityService;
+
+    @GetMapping("/{login}")
+    public ResponseEntity<ActivityDTO> getActivityByUser(@PathVariable String login) {
+        ActivityDTO activity = activityService.getActivity(login);
+        return ResponseEntity.ok(activity);
+    }
+
+    @PostMapping("/user/{login}/badpractices")
+    public ResponseEntity<List<PullRequestBadPracticeDTO>> detectBadPracticesByUser(@PathVariable String login) {
+        List<PullRequestBadPracticeDTO> badPractices = activityService.detectBadPracticesForUser(login);
+        return ResponseEntity.ok(badPractices);
+    }
+
+    @PostMapping("/pullrequest/{pullRequestId}/badpractices")
+    public ResponseEntity<List<PullRequestBadPracticeDTO>> detectBadPracticesForPullRequest(
+        @PathVariable Long pullRequestId
+    ) {
+        List<PullRequestBadPracticeDTO> badPractice = activityService.detectBadPracticesForPullRequest(pullRequestId);
+        return ResponseEntity.ok(badPractice);
+    }
+}

server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/ActivityService.java

@@ -0,0 +1,100 @@
+package de.tum.in.www1.hephaestus.activity;
+
+import de.tum.in.www1.hephaestus.activity.badpracticedetector.PullRequestBadPracticeDetector;
+import de.tum.in.www1.hephaestus.activity.model.*;
+import de.tum.in.www1.hephaestus.gitprovider.issue.Issue;
+import de.tum.in.www1.hephaestus.gitprovider.pullrequest.PullRequest;
+import de.tum.in.www1.hephaestus.gitprovider.pullrequest.PullRequestRepository;
+import de.tum.in.www1.hephaestus.gitprovider.user.UserRepository;
+import jakarta.transaction.Transactional;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Service;
+
+@Service
+public class ActivityService {
+
+    private static final Logger logger = LoggerFactory.getLogger(ActivityService.class);
+
+    @Autowired
+    private PullRequestRepository pullRequestRepository;
+
+    @Autowired
+    private PullRequestBadPracticeRepository pullRequestBadPracticeRepository;
+
+    @Autowired
+    private PullRequestBadPracticeDetector pullRequestBadPracticeDetector;
+
+    @Autowired
+    private UserRepository userRepository;
+
+    public ActivityDTO getActivity(String login) {
+        logger.info("Getting activity for user with login: {}", login);
+
+        List<PullRequest> pullRequests = pullRequestRepository.findAssignedByLoginAndStates(
+            login,
+            Set.of(Issue.State.OPEN)
+        );
+
+        List<PullRequestBadPractice> openPulLRequestBadPractices =
+            pullRequestBadPracticeRepository.findAssignedByLoginAndOpen(login);
+
+        Map<PullRequest, List<PullRequestBadPracticeDTO>> pullRequestBadPracticesMap = openPulLRequestBadPractices
+            .stream()
+            .collect(
+                Collectors.groupingBy(
+                    PullRequestBadPractice::getPullrequest,
+                    Collectors.collectingAndThen(Collectors.toList(), list ->
+                        list.stream().map(PullRequestBadPracticeDTO::fromPullRequestBadPractice).toList()
+                    )
+                )
+            );
+
+        List<PullRequestWithBadPracticesDTO> openPullRequestsWithBadPractices = pullRequests
+            .stream()
+            .map(pullRequest ->
+                PullRequestWithBadPracticesDTO.fromPullRequest(
+                    pullRequest,
+                    pullRequestBadPracticesMap.getOrDefault(pullRequest, List.of())
+                )
+            )
+            .collect(Collectors.toList());
+
+        return new ActivityDTO(openPullRequestsWithBadPractices);
+    }
+
+    public List<PullRequestBadPracticeDTO> detectBadPracticesForUser(String login) {
+        logger.info("Detecting bad practices for user with login: {}", login);
+
+        List<PullRequest> pullRequests = pullRequestRepository.findAssignedByLoginAndStates(
+            login,
+            Set.of(Issue.State.OPEN)
+        );
+
+        List<PullRequestBadPractice> detectedBadPractices = new ArrayList<>();
+        for (PullRequest pullRequest : pullRequests) {
+            detectedBadPractices.addAll(pullRequestBadPracticeDetector.detectAndSyncBadPractices(pullRequest));
+        }
+        return detectedBadPractices.stream().map(PullRequestBadPracticeDTO::fromPullRequestBadPractice).toList();
+    }
+
+    public List<PullRequestBadPracticeDTO> detectBadPracticesForPullRequest(Long pullRequestId) {
+        logger.info("Detecting bad practices for PR: {}", pullRequestId);
+
+        PullRequest pullRequest = pullRequestRepository.findById(pullRequestId).orElse(null);
+        if (pullRequest == null) {
+            throw new IllegalArgumentException("Pull request " + pullRequestId + " not found");
+        }
+
+        List<PullRequestBadPractice> detectedBadPractices = pullRequestBadPracticeDetector.detectAndSyncBadPractices(
+            pullRequest
+        );
+        return detectedBadPractices.stream().map(PullRequestBadPracticeDTO::fromPullRequestBadPractice).toList();
+    }
+}

server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/PullRequestBadPracticeRepository.java

@@ -0,0 +1,32 @@
+package de.tum.in.www1.hephaestus.activity;
+
+import de.tum.in.www1.hephaestus.activity.model.PullRequestBadPractice;
+import jakarta.transaction.Transactional;
+import java.util.List;
+import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.data.jpa.repository.Query;
+import org.springframework.data.repository.query.Param;
+import org.springframework.stereotype.Repository;
+
+@Repository
+public interface PullRequestBadPracticeRepository extends JpaRepository<PullRequestBadPractice, Long> {
+    @Transactional
+    @Query(
+        """
+        SELECT prbp
+        FROM PullRequestBadPractice prbp
+        WHERE LOWER(:assigneeLogin) IN (SELECT LOWER(u.login) FROM prbp.pullrequest.assignees u) AND prbp.pullrequest.state = 'OPEN'
+        """
+    )
+    List<PullRequestBadPractice> findAssignedByLoginAndOpen(@Param("assigneeLogin") String assigneeLogin);
+
+    @Transactional
+    @Query(
+        """
+        SELECT prbp
+        FROM PullRequestBadPractice prbp
+        WHERE prbp.pullrequest.id = :pullRequestId
+        """
+    )
+    List<PullRequestBadPractice> findByPullRequestId(@Param("pullRequestId") long pullRequestId);
+}

server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/badpracticedetector/BadPracticeDetectorScheduler.java

@@ -0,0 +1,34 @@
+package de.tum.in.www1.hephaestus.activity.badpracticedetector;
+
+import de.tum.in.www1.hephaestus.gitprovider.label.Label;
+import de.tum.in.www1.hephaestus.gitprovider.pullrequest.PullRequest;
+import java.util.Set;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Qualifier;
+import org.springframework.core.task.TaskExecutor;
+import org.springframework.stereotype.Component;
+
+@Component
+public class BadPracticeDetectorScheduler {
+
+    private static final String READY_TO_MERGE = "ready to merge";
+
+    @Qualifier("applicationTaskExecutor")
+    @Autowired
+    TaskExecutor taskExecutor;
+
+    public void detectBadPracticeForPrIfReadyToMerge(
+        PullRequest pullRequest,
+        Set<Label> oldLabels,
+        Set<Label> newLabels
+    ) {
+        if (
+            newLabels.stream().anyMatch(label -> READY_TO_MERGE.equals(label.getName())) &&
+            oldLabels.stream().noneMatch(label -> READY_TO_MERGE.equals(label.getName()))
+        ) {
+            BadPracticeDetectorTask badPracticeDetectorTask = new BadPracticeDetectorTask();
+            badPracticeDetectorTask.setPullRequest(pullRequest);
+            taskExecutor.execute(badPracticeDetectorTask);
+        }
+    }
+}

server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/badpracticedetector/BadPracticeDetectorTask.java

@@ -0,0 +1,23 @@
+package de.tum.in.www1.hephaestus.activity.badpracticedetector;
+
+import de.tum.in.www1.hephaestus.gitprovider.pullrequest.PullRequest;
+import lombok.Getter;
+import lombok.Setter;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Component;
+
+@Component
+@Getter
+@Setter
+public class BadPracticeDetectorTask implements Runnable {
+
+    @Autowired
+    private PullRequestBadPracticeDetector pullRequestBadPracticeDetector;
+
+    private PullRequest pullRequest;
+
+    @Override
+    public void run() {
+        pullRequestBadPracticeDetector.detectAndSyncBadPractices(pullRequest);
+    }
+}