Adding matching component (incl detailed docu) #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rappm
previously approved these changes
Jan 18, 2025
| <AlertCircle className='h-4 w-4' /> | ||
| <AlertTitle>Error</AlertTitle> | ||
| <AlertDescription> | ||
| We're sorry, but we couldn't load the matching routes. Please try refreshing |
There was a problem hiding this comment.
very minor: I would prefer refreshing the page instead of just refreshing
# Conflicts: # .github/workflows/deploy-docker.yml # clients/core/Dockerfile
niclasheun
temporarily deployed
to
prompt-dev-vm
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solely contains changes related to adding a new course phase.
Further it includes a detailed readme which explains the process of adding a new mircofrontend in a step by step guide.
@mathildeshagl @rappm please go through the code and readme and check if all changes are understandably described and reflected in the readme. If something is unclear/missing, please provide a comment with concrete suggestions.