Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interview Component #83

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Interview Component #83

wants to merge 30 commits into from

Conversation

niclasheun
Copy link
Contributor

This pull request includes several changes aimed at improving the interview component and refactoring imports for better maintainability. The most important changes include the introduction of new components for interview management, refactoring of import paths, and handling errors more effectively.

Features of Interview Component:

  • Overview of all students in the interview phase
  • Detail view with the application of the student and the possibility to save interview comments
  • Ability to set interview timeslots
  • Ability to set interview questions

Known Issues:

  • Currently the "Set interview button" is disabled. Reason: As we do not yet have a shared library, it is impossible to access the user data from the subcomponent. This will be fixed as soon as the shared library is in place
  • The Dialogs (InterviewTimes and InterviewQuestions) have a fixed height. This is required, as otherwise the scrolling does not correctly work. But this is only a minor "Design issue"

@niclasheun
initial design interview component
2edaace
@niclasheun
adjusting card design
852fd8f
@niclasheun
Adding Details Page
6b84605
@niclasheun
adjusting student profile
87c47cd
@niclasheun
change clicking logic
d22a800
@niclasheun
some changes
4a49516
@niclasheun
Merge branch 'main' into interview-component-inital-design
92ac760
@niclasheun
Merge branch 'main' into interview-component-inital-design
3db1c0a
@niclasheun
adjusting interview overview page
07e646e
@niclasheun
unifying icon usage
2ca2f68
@niclasheun
Merge branch 'main' into interview-component-inital-design
44cb8c8
@niclasheun
adding application display in interview
70a3d32
@niclasheun
adding gravatar size support
8faf877
@niclasheun
adding sorting dropdown
f12ce82
@niclasheun
Merge branch 'main' into interview-component-inital-design
75ceff8
@niclasheun
adjusting data fetching
e881d69
@niclasheun
working interview questions modal
28bb146
@niclasheun
adjusting button
40c391b
@niclasheun
improving design
064a80f
@niclasheun
storing the application answers
248baf9
@niclasheun
adjusting interview card
c469215
@niclasheun
improving adding a question
957a07a
@niclasheun
adjusting score
c1110df
@niclasheun
adding initial design interview slots
fc5bb77
@niclasheun
finishing functionality
7a22b9f
@niclasheun
code cleanup
7fc2167
@niclasheun niclasheun self-assigned this Jan 21, 2025
@niclasheun niclasheun linked an issue Jan 21, 2025 that may be closed by this pull request
Implement Interview Phase #80
Open
@niclasheun niclasheun requested a review from Mtze January 21, 2025 12:54
@niclasheun
Copy link
Contributor Author

@Mtze Die Interview Component ist soweit fertig und deployed. Schau es dir gerne mal an.
Bin happy über Vorschläge noch Sachen anzupassen / zu verbessen

@niclasheun
Merge branch 'main' into interview-component-inital-design
35eccb8 
# Conflicts:
#	clients/core/src/ApplicationAdministration/Application.tsx
#	clients/core/src/ApplicationAdministration/ApplicationAssessment/ApplicationsOverview.tsx
#	clients/core/src/ApplicationAdministration/pages/Mailing/ApplicationMailingSettings.tsx
@niclasheun niclasheun deployed to prompt-dev-vm January 21, 2025 16:46 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mtze Mtze Awaiting requested review from Mtze

At least 1 approving review is required to merge this pull request.

Assignees

@niclasheun niclasheun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Interview Phase
1 participant
@niclasheun