Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-49384: Restore some sort of caching for downloading HD 111980 from simbad #59

Open
wants to merge 7 commits into
base: lsst-dev
Choose a base branch
from

Conversation

erykoff
Copy link

@erykoff erykoff commented Mar 7, 2025

With rubinenv 9 we had astroquery 0.4.6 which supported caching, so we could store the cached version of the HD 111980 simbad table and it would use that. As of astroquery 0.4.8 they completely refactored the query system / units / fields / etc and also remove all caching ability.

I tried using vcr, but that crashed on record (some incompatibility between pyvo and new vcrpy maybe? I don’t know).

So my solution is to put special-case code in spectractor when running on jenkins. It’s not pretty, but it does work locally (at least).

@coveralls
Copy link

coveralls commented Mar 7, 2025

Pull Request Test Coverage Report for Build 13740764646

Details

  • 10 of 27 (37.04%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 71.391%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/test_extractor.py 2 3 66.67%
tests/test_fullchain.py 2 3 66.67%
spectractor/extractor/targets.py 3 6 50.0%
spectractor/tools.py 2 14 14.29%
Totals Coverage Status
Change from base Build 13558643118: -0.02%
Covered Lines: 5757
Relevant Lines: 8064

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants