Merge pull request #291 from lsst/tickets/DM-48468

DM-48468: Turn off gaussian histogram Ks testing by default.
lsst · Jan 22, 2025 · 5dc75b4 · 5dc75b4
2 parents 235520f + 5c67fd1
commit 5dc75b4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/python/lsst/cp/pipe/ptc/cpPtcExtract.py b/python/lsst/cp/pipe/ptc/cpPtcExtract.py
@@ -201,6 +201,12 @@ class PhotonTransferCurveExtractConfig(pipeBase.PipelineTaskConfig,
             'FULL': 'Second order correction.'
         }
     )
+    doKsHistMeasurement = pexConfig.Field(
+        dtype=bool,
+        doc="Do the Ks test of gaussianity? If False, kspValue will be filled "
+            "with all 1.0s.",
+        default=False,
+    )
     ksHistNBins = pexConfig.Field(
         dtype=int,
         doc="Number of bins for the KS test histogram.",
@@ -693,9 +699,9 @@ def run(self, inputExp, inputDims, taskMetadata=None, inputPhotodiodeData=None):
                 # the combined dataset).
                 covArray[0, 0, 0] /= varFactor
 
-                if expIdMask:
+                if expIdMask and self.config.doKsHistMeasurement:
                     # Run the Gaussian histogram only if this is a legal
-                    # amplifier.
+                    # amplifier and configured to do so.
                     histVar, histChi2Dof, kspValue = self.computeGaussianHistogramParameters(
                         im1Area,
                         im2Area,
@@ -706,7 +712,12 @@ def run(self, inputExp, inputDims, taskMetadata=None, inputPhotodiodeData=None):
                 else:
                     histVar = np.nan
                     histChi2Dof = np.nan
-                    kspValue = 0.0
+                    if self.config.doKsHistMeasurement:
+                        kspValue = 0.0
+                    else:
+                        # When this is turned off, we will always allow it to
+                        # pass downstream.
+                        kspValue = 1.0
 
                 if self.config.doExtractPhotodiodeData or self.config.useEfdPhotodiodeData:
                     nExps = 0

diff --git a/tests/test_ptc.py b/tests/test_ptc.py
@@ -146,6 +146,7 @@ def test_covAstier(self):
         extractConfig.minNumberGoodPixelsForCovariance = 5000
         extractConfig.detectorMeasurementRegion = "FULL"
         extractConfig.doExtractPhotodiodeData = True
+        extractConfig.doKsHistMeasurement = True
         extractConfig.auxiliaryHeaderKeys = ["CCOBCURR", "CCDTEMP"]
         extractTask = cpPipe.ptc.PhotonTransferCurveExtractTask(config=extractConfig)