DM-42116: Add numpydoc validation #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 86.96% 87.16% +0.19%
==========================================
Files 49 49
Lines 4441 4424 -17
Branches 769 765 -4
==========================================
- Hits 3862 3856 -6
+ Misses 425 415 -10
+ Partials 154 153 -1 ☔ View full report in Codecov by Sentry. |
timj
force-pushed
the
tickets/DM-42116
branch
from
686046e to
6b66f89
Compare
dhirving
approved these changes
Dec 13, 2023
Comment on lines
-56
to
-58
| def profile(filename: str, log: logging.Logger | None = None) -> Iterator: | ||
| """Context manager for profiling with cProfile | ||
|
|
There was a problem hiding this comment.
Just want to check and confirm that this is fully private and safe to remove
There was a problem hiding this comment.
It is a helper function for the --profile option and is identical to the version in lsst.utils. I removed the code duplication and the function (and lsst.ctrl.mpexec.util) was never meant to be public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes