Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48589: Fix timespans in DimensionRecordTable empty #1150

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Feb 3, 2025

Fix an issue where timespans in dimension records read out of DimensionRecordTable would always be empty, due to an error in the deserialization logic.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Fix an issue where timespans in DimensionRecord read out of DimensionRecordTable would always be empty, due to an error in the deserialization logic.
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (3a57374) to head (68342b1).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1150   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files         366      366           
  Lines       49115    49123    +8     
  Branches     5955     5955           
=======================================
+ Hits        43944    43952    +8     
  Misses       3753     3753           
  Partials     1418     1418           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhirving dhirving marked this pull request as ready for review February 3, 2025 23:23
@dhirving dhirving requested a review from TallJimbo February 3, 2025 23:23
@dhirving dhirving merged commit 19513f1 into main Feb 4, 2025
19 checks passed
@dhirving dhirving deleted the tickets/DM-48589 branch February 4, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants