Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48589: Fix deserialization of nulls from Arrow Timespan #1153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Feb 7, 2025

Fix a bug where null values in nullable arrow Timespan columns would raise an exception when deserializing an Arrow Table to python.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Fix a bug where null values in nullable arrow Timespan columns would raise an exception when  deserializing an Arrow Table to python.
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (e060d3e) to head (abc812b).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1153   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files         367      367           
  Lines       49190    49198    +8     
  Branches     5959     5960    +1     
=======================================
+ Hits        44014    44022    +8     
  Misses       3757     3757           
  Partials     1419     1419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhirving dhirving requested a review from TallJimbo February 7, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants