Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38497: Introduce special syntax for binds #1166

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andy-slac
Copy link
Contributor

@andy-slac andy-slac commented Mar 11, 2025

Expression parser adds a new syntax which specifies bind identifiers.
Those identifiers are the names prefixed with colon, e.g. :bind_name.
The names are presumed to be bind names, as opposed to usual identifiers
that could be either bind names or any other sort of identifiers.

Eventually we want to deprecate simple identifier use for binds, for now
there are no deprecation warnings issued for old syntax.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 90.79755% with 15 lines in your changes missing coverage. Please review.

Project coverage is 89.35%. Comparing base (cf779c4) to head (0ecc300).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../butler/registry/queries/expressions/_predicate.py 63.15% 4 Missing and 3 partials ⚠️
...hon/lsst/daf/butler/queries/_expression_strings.py 60.00% 1 Missing and 1 partial ⚠️
...t/daf/butler/registry/queries/expressions/check.py 80.00% 1 Missing and 1 partial ⚠️
tests/test_exprParserYacc.py 96.66% 2 Missing ⚠️
...er/registry/queries/expressions/parser/exprTree.py 87.50% 1 Missing ⚠️
tests/test_normalFormExpression.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
- Coverage   89.36%   89.35%   -0.01%     
==========================================
  Files         367      367              
  Lines       49548    49651     +103     
  Branches     6016     6019       +3     
==========================================
+ Hits        44277    44368      +91     
- Misses       3852     3860       +8     
- Partials     1419     1423       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Expression parser adds a new syntax which specifies bind identifiers.
Those identifiers are the names prefixed with colon, e.g. `:bind_name`.
The names are presumed to be bind names, as opposed to usual identifiers
that could be either bind names or any other sort of identifiers.

Eventually we want to deprecate simple identifier use for binds, for now
there are no deprecation warnings issued for old syntax.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant