DM-48783: Add illumination correction support to SubtractBackgroundTask and SourceDetectionTask #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Feb 19, 2025
| @@ -291,6 +293,8 @@ def detectFootprints(self, exposure, doSmooth=True, sigma=None, clearMask=True, | |||
| Results from preliminary detection pass. | |||
| (`lsst.pipe.base.Struct`) | |||
| """ | |||
| if backgroundToPhotometricRatio is not None: | |||
| raise RuntimeError("DynamicDetectionTask does not support backgroundToPhotometricRatio.") | |||
There was a problem hiding this comment.
It might be worth it to add a config validate check for this, too.
| do anything. | ||
| backgroundToPhotometricRatio : `lsst.afw.image.Image`, optional | ||
| Image to convert background-flattened image to | ||
| photometric-flattened image (and back). |
There was a problem hiding this comment.
When you fixed the implementation on the later commit, I don't think the docs had to change, because I don't feel like "apply" implies either "multiply" or "divide". But I also think we want the docs to talk about going from a photometric-flattened image to a backtround-flattened one and back, since that's what the context actually does. How about:
Image to multiply a photometrically-flattened image by to obtain a background-flattened image.
erykoff
force-pushed
the
tickets/DM-48783
branch
from
1df3246 to
4e00952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also adds some unit tests for SubtractBackgroundTask and the background re-estimation in SourceDetectionTask.