DM-35396: Add dataset provenance to FITS headers #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-35396
branch
from
5af8e22 to
108fdc6
Compare
TallJimbo
approved these changes
Jan 27, 2025
timj
force-pushed
the
tickets/DM-35396
branch
3 times, most recently
from
14b421b to
e9527a7
Compare
andy-slac
approved these changes
Jan 31, 2025
|
|
||
| # Purge old headers from metadata (important for data ID and input headers | ||
| # and to prevent headers accumulating in a PropertyList). | ||
| for k in hdr: |
There was a problem hiding this comment.
Hmm, does this need list(hdr) if you delete items during iteration?
| from lsst.resources import ResourcePath | ||
| from lsst.utils.classes import cached_getter | ||
| from lsst.utils.introspection import find_outside_stacklevel | ||
|
|
||
|
|
||
| def add_provenance_to_fits_header( | ||
| hdr: PropertyList | MutableMapping, ref: DatasetRef, provenance: DatasetProvenance | None = None |
There was a problem hiding this comment.
Suggested change
| hdr: PropertyList | MutableMapping, ref: DatasetRef, provenance: DatasetProvenance | None = None | |
| hdr: PropertyList | MutableMapping | None, ref: DatasetRef, provenance: DatasetProvenance | None = None |
?
This adds "LSST BUTLER" headers to reflect the DatasetRef associated with this file.
This turned up in fgcmcal testing.
timj
force-pushed
the
tickets/DM-35396
branch
from
a9aff7d to
0d16388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires lsst/daf_butler#1147.
Checklist
doc/changes