Skip to content

DM-44648: Allow conflicting module paths to be resolved late #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

natelust
Copy link
Contributor

@natelust natelust commented Jun 4, 2024

When instantiating a pipeline that contains imports, allow the system to resolve conflicting module paths of tasks late. This allows the same task imported from a different path to still resolve as the same.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 79.23077% with 27 lines in your changes missing coverage. Please review.

Project coverage is 82.08%. Comparing base (e430572) to head (c79df71).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
python/lsst/pipe/base/tests/simpleQGraph.py 54.54% 15 Missing ⚠️
python/lsst/pipe/base/pipelineIR.py 80.43% 5 Missing and 4 partials ⚠️
python/lsst/pipe/base/pipeline.py 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
- Coverage   82.09%   82.08%   -0.02%     
==========================================
  Files         107      108       +1     
  Lines       12995    13114     +119     
  Branches     1678     1693      +15     
==========================================
+ Hits        10668    10764      +96     
- Misses       1905     1926      +21     
- Partials      422      424       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but codecov has spotted some logic branches the new tests didn't cover, and it doesn't look at first glance like it'd be hard to include them.

@natelust natelust force-pushed the tickets/DM-44648 branch from b99eaf5 to 9c5f990 Compare July 2, 2024 15:39
When instantiating a pipeline that contains imports, allow the system
to resolve conflicting module paths of tasks late. This allows the
same task imported from a different path to still resolve as the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants